[PATCH] D137434: [lit] Add `target=<triple>` as a feature keyword

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D137434#3913083 <https://reviews.llvm.org/D137434#3913083>, @dblaikie wrote:

> This is to detect the current/default target?

This is to allow checking the default target in a more principled way.  Currently UNSUPPORTED/XFAIL (but not REQUIRES) can use arbitrary substrings of the default target triple as "feature keywords" and the end goal here is to replace all those with regexes against `target=<triple>` (thus allowing REQUIRES to check the target triple as well).

> Should we instead support something more like the one in cross-project-tests, that adds a feature for every registered target? (that way a test can declare that it runs any time x86-registered-target is available, and it can specify the x86 target, so the test would run even on arm-default builds, for instance, so long as they also included x86?)

That's not what I see cross-project-tests doing; it's checking whether any of the registered targets match the _host_ because it wants to be able to build/test executable programs running on the host.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137434/new/

https://reviews.llvm.org/D137434