[PATCH] D132224: [Assignment Tracking][5/*] Add core infrastructure for instruction reference

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 12:24:28 PST 2022


rastogishubham added a comment.

This patch also breaks an LLDB test on Apple Silicon:

https://ci.swift.org/view/LLDB/job/llvm-org-lldb-release-debuginfo/658/consoleFull

  ******************** TEST 'lldb-shell :: ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   mkdir -p /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/tools/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Output/app_specific_backtrace_crashlog.test.tmp.dir
  : 'RUN: at line 4';   /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/bin/yaml2obj /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/llvm-project/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.yaml > /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/tools/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Output/app_specific_backtrace_crashlog.test.tmp.dir/asi
  : 'RUN: at line 5';   /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/bin/lldb --no-lldbinit -S /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/tools/lldb/test/Shell/lit-lldb-init-quiet -o 'command script import lldb.macosx.crashlog'  -o 'crashlog -a -i -t /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/tools/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Output/app_specific_backtrace_crashlog.test.tmp.dir/asi /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/llvm-project/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.ips'  -o "thread list" -o "bt all" 2>&1 | /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/bin/FileCheck /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/llvm-project/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/llvm-project/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test:47:15: error: CHECK-NEXT: expected string not found in input
  # CHECK-NEXT: frame #6: 0x00000001a05d3e4f dyld`start{{.*}}
                ^
  <stdin>:42:45: note: scanning from here
   frame #5: 0x00000001047e3ecf asi`main + 127
                                              ^
  <stdin>:43:2: note: possible intended match here
   frame #6: 0x00000001a05d3e4f
   ^
  
  Input file: <stdin>
  Check file: /Users/ec2-user/jenkins/workspace/llvm-org-lldb-release-debuginfo/llvm-project/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             .
             .
             .
            37:  frame #0: 0x00000001a0a58418 
            38:  frame #1: 0x00000001a05a2ea7 
            39:  frame #2: 0x00000001a0b3dcc3 
            40:  frame #3: 0x00000001a0b46af3 
            41:  frame #4: 0x00000001a09a12a3 
            42:  frame #5: 0x00000001047e3ecf asi`main + 127 
  next:47'0                                                 X error: no match found
            43:  frame #6: 0x00000001a05d3e4f 
  next:47'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  next:47'1      ?                             possible intended match
            44: (lldb) thread list 
  next:47'0     ~~~~~~~~~~~~~~~~~~~
            45: Process 96535 stopped 
  next:47'0     ~~~~~~~~~~~~~~~~~~~~~~
            46: * thread #1: tid = 0x1af8f3, 0x00000001a08c7224, queue = 'com.apple.main-thread', stop reason = EXC_CRASH (code=0, subcode=0x0) 
  next:47'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            47: (lldb) bt all 
  next:47'0     ~~~~~~~~~~~~~~
            48: * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_CRASH (code=0, subcode=0x0) 
  next:47'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
  >>>>>>
  
  --
  
  ********************

Could you please revert the patch and fix the issues?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132224/new/

https://reviews.llvm.org/D132224



More information about the llvm-commits mailing list