[PATCH] D137535: [CodeGen][BasicBlockSections] Fix wrong alignment directive placement in basic block section cases

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 11:17:11 PST 2022


rahmanl added a comment.

Thanks for this fix.



================
Comment at: llvm/test/CodeGen/X86/align-basic-block-sections.ll:1
+; RUN: llc < %s -march=x86-64 --basic-block-sections=all --unique-basic-block-section-names | FileCheck %s --check-prefix=ASM
+; RUN: llc < %s -march=x86-64 --basic-block-sections=all --unique-basic-block-section-names -filetype=obj -o - | obj2yaml | FileCheck %s --check-prefix=OBJ
----------------
Can you please simplify the test and check the assembly only to make sure the alignment directive is placed at the right position?
You might want to use `-align-all-blocks` or `-align-all-nofallthru-blocks` and then use a simple if-then-else statement to trigger alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137535/new/

https://reviews.llvm.org/D137535



More information about the llvm-commits mailing list