[PATCH] D137549: [AsmParser] Match mandatory operands following optional operands.

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/gfx10_err_pos.s:7
 image_atomic_add v252, v2, s[8:15]
-// CHECK: error: dim modifier is required on this GPU
+// CHECK: error: operands are not valid for this GPU or mode
 // CHECK-NEXT:{{^}}image_atomic_add v252, v2, s[8:15]
----------------
Could you also rename the section?


================
Comment at: llvm/test/MC/AMDGPU/gfx10_err_pos.s:973
 buffer_load_dword off, s[8:11], s3
-// CHECK: error: missing dst operand or lds modifier
+// CHECK: error: too few operands for instruction
 // CHECK-NEXT:{{^}}buffer_load_dword off, s[8:11], s3
----------------
This and the following test should be moved to another section.


================
Comment at: llvm/test/MC/AMDGPU/gfx9_err_pos.s:185
 buffer_load_dword off, s[8:11], s3
-// CHECK: error: missing dst operand or lds modifier
+// CHECK: error: too few operands for instruction
 // CHECK-NEXT:{{^}}buffer_load_dword off, s[8:11], s3
----------------
Could you also rename the section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137549/new/

https://reviews.llvm.org/D137549