[PATCH] D137341: [VectorCombine] widen a load with subvector insert

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 10:41:36 PST 2022


arsenm added a comment.

In D137341#3912961 <https://reviews.llvm.org/D137341#3912961>, @spatel wrote:

> stripPointerCastsSameRepresentation() avoids the crash, but then we don't capture the expected alignment from the ptr param.

For alignment purposes, stripPointerCasts is OK.

However, why does the vector combiner need to look at the underlying pointer for the alignment? Doesn't instcombine increase the alignment based on the underlying pointer already, such that this can just read the alignment direct from the instruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137341/new/

https://reviews.llvm.org/D137341



More information about the llvm-commits mailing list