[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Makes sense to me.  Maybe someone more familiar with the SystemZ side of things can confirm.

> (as a newbie here I'm curious on what would break..?)

Off the top of my head:

- Other code could create internal globals
- Name conflict if multiple globals have the same name
- C++ name mangling might get confused.



================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:3217
   SDValue Result;
-  if (Subtarget.isPC32DBLSymbol(GV, CM)) {
+  if (!NoPicDataIsTextRelative && Subtarget.isPC32DBLSymbol(GV, CM)) {
     if (isInt<32>(Offset)) {
----------------
Move this check into isPC32DBLSymbol, maybe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137044/new/

https://reviews.llvm.org/D137044