[PATCH] D137569: [SLP][NFC] Restructure areTwoInsertFromSameBuildVector
krishna chaitanya sankisa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 7 09:41:06 PST 2022
skc7 created this revision.
skc7 added reviewers: ABataev, bcahoon.
Herald added subscribers: vporpo, hiraditya.
Herald added a project: All.
skc7 requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead.
Herald added a project: LLVM.
Fix areTwoInsertFromSameBuildVector to check for valid insert index of insertElement instructions.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D137569
Files:
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
Index: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -7165,8 +7165,10 @@
return false;
auto *IE1 = VU;
auto *IE2 = V;
- unsigned Idx1 = *getInsertIndex(IE1);
- unsigned Idx2 = *getInsertIndex(IE2);
+ Optional<unsigned> Idx1 = getInsertIndex(IE1);
+ Optional<unsigned> Idx2 = getInsertIndex(IE2);
+ if (Idx1 == None || Idx2 == None)
+ return false;
// Go through the vector operand of insertelement instructions trying to find
// either VU as the original vector for IE2 or V as the original vector for
// IE1.
@@ -7177,14 +7179,14 @@
return V->hasOneUse();
if (IE1) {
if ((IE1 != VU && !IE1->hasOneUse()) ||
- getInsertIndex(IE1).value_or(Idx2) == Idx2)
+ getInsertIndex(IE1).value_or(*Idx2) == *Idx2)
IE1 = nullptr;
else
IE1 = dyn_cast_or_null<InsertElementInst>(GetBaseOperand(IE1));
}
if (IE2) {
if ((IE2 != V && !IE2->hasOneUse()) ||
- getInsertIndex(IE2).value_or(Idx1) == Idx1)
+ getInsertIndex(IE2).value_or(*Idx1) == *Idx1)
IE2 = nullptr;
else
IE2 = dyn_cast_or_null<InsertElementInst>(GetBaseOperand(IE2));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137569.473720.patch
Type: text/x-patch
Size: 1343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/8dcaf9b1/attachment.bin>
More information about the llvm-commits
mailing list