[PATCH] D137567: [SLP][NFC] Restructure getInsertIndex

krishna chaitanya sankisa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 09:37:39 PST 2022


skc7 created this revision.
skc7 added reviewers: ABataev, bcahoon.
Herald added subscribers: vporpo, arphaman, hiraditya.
Herald added a project: All.
skc7 requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, alextsao1999.
Herald added a project: LLVM.

Fix getInsertIndex to correctly cast to FixedVectorType. 
This is required because insertElement instructions can use scalable vectors aswell.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137567

Files:
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp


Index: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -291,12 +291,13 @@
   int Index = Offset;
   if (const auto *IE = dyn_cast<InsertElementInst>(InsertInst)) {
     if (const auto *CI = dyn_cast<ConstantInt>(IE->getOperand(2))) {
-      auto *VT = cast<FixedVectorType>(IE->getType());
-      if (CI->getValue().uge(VT->getNumElements()))
-        return None;
-      Index *= VT->getNumElements();
-      Index += CI->getZExtValue();
-      return Index;
+      if (const auto *VT = dyn_cast<FixedVectorType>(IE->getType())) {
+        if (CI->getValue().uge(VT->getNumElements()))
+          return None;
+        Index *= VT->getNumElements();
+        Index += CI->getZExtValue();
+        return Index;
+      }
     }
     return None;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137567.473717.patch
Type: text/x-patch
Size: 926 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/21af805f/attachment.bin>


More information about the llvm-commits mailing list