[PATCH] D135685: [Visualizers] Add natvis visualizers for various internal llvm classes

Mon Nov 7 08:49:32 PST 2022

Trass3r added inline comments.

================
Comment at: llvm/utils/LLVMVisualizers/llvm.natvis:304
+  <Type Name="llvm::SDNode">
+    <DisplayString>$(Type) {getOperationName(nullptr)}</DisplayString>
+    <Expand>
----------------
RKSimon wrote:
> Trass3r wrote:
> > RKSimon wrote:
> > > Does this work? It always seems to display "{llvm::SDNode ???}" for me
> > > 
> > The method still exists, maybe something goes wrong when it tries to call it?
> Does it work for you? I'm using VS2022 here.
> 
> Otherwise maybe we just cast to (llvm::ISD::NodeType) if < BUILTIN_OP_END ? We can keep the getOperationName call as the fallback
It may have been an unfinished experiment. I replaced it with the NodeType to keep it simple.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135685/new/

https://reviews.llvm.org/D135685