[PATCH] D137423: [PowerPC][WIP] make expensive mflr be awfy from its user in the function prologue

Roland Froese via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 07:59:40 PST 2022


RolandF added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:621
+  // expensive. We need to consider the latency when backup lr in the prologue.
+  const bool IsCheapMFLR = Subtarget.isISA3_1();
+
----------------
The cost of an mflr is a characteristic of an implementation, not of the architecture.  A future processor might have a slow mflr.  I think a new subtarget feature is needed for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137423/new/

https://reviews.llvm.org/D137423



More information about the llvm-commits mailing list