[PATCH] D137555: [cmake] Add missing CMakePushCheckState include to FindLibEdit.cmake

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 07:48:10 PST 2022


mgorny created this revision.
mgorny added reviewers: thesamesam, MaskRay, phosek, tstellar, upsj.
Herald added a subscriber: StephenFan.
Herald added a project: All.
mgorny requested review of this revision.

Add the missing include to fix an error when `cmake_push_check_state()`
is called and incidentally the CMakePushCheckState module is not loaded
by any other check running prior to `FindLibEdit.cmake`:

  CMake Error at /var/no-tmpfs/portage/dev-util/lldb-15.0.4/work/cmake/Modules/FindLibEdit.cmake:24 (cmake_push_check_state):
    Unknown CMake command "cmake_push_check_state".
  Call Stack (most recent call first):
    cmake/modules/LLDBConfig.cmake:52 (find_package)
    cmake/modules/LLDBConfig.cmake:59 (add_optional_dependency)
    CMakeLists.txt:28 (include)

Gentoo Bug: https://bugs.gentoo.org/880065


https://reviews.llvm.org/D137555

Files:
  cmake/Modules/FindLibEdit.cmake


Index: cmake/Modules/FindLibEdit.cmake
===================================================================
--- cmake/Modules/FindLibEdit.cmake
+++ cmake/Modules/FindLibEdit.cmake
@@ -21,6 +21,7 @@
 
 include(CheckIncludeFile)
 if(LibEdit_INCLUDE_DIRS AND EXISTS "${LibEdit_INCLUDE_DIRS}/histedit.h")
+  include(CMakePushCheckState)
   cmake_push_check_state()
   list(APPEND CMAKE_REQUIRED_INCLUDES ${LibEdit_INCLUDE_DIRS})
   list(APPEND CMAKE_REQUIRED_LIBRARIES ${LibEdit_LIBRARIES})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137555.473673.patch
Type: text/x-patch
Size: 486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/7fcf34d9/attachment.bin>


More information about the llvm-commits mailing list