[PATCH] D124325: [AArch64][SVE] Support logical operation BIC with DestructiveBinary patterns
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 7 07:13:46 PST 2022
Allen added a comment.
In D124325#3911789 <https://reviews.llvm.org/D124325#3911789>, @paulwalker-arm wrote:
> @Allen Did you see my comment from "Wed, Nov 2, 2:34 PM"? Not a requirement but I figure moving this code out of DEBUG and ensuring `DOPRegIsUnique` is correct for `AArch64::DestructiveBinary` might be better in the long run. I know at this time you only care about DestructiveBinary, but I think your solution can easily be extended to the other destructive types later on, although part of me thinks they'll just work after this patch.
sorry @paulwalker-arm for missing that. Now I deleted the DEBUG.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124325/new/
https://reviews.llvm.org/D124325
More information about the llvm-commits
mailing list