[PATCH] D137551: [WebAssembly] Use default attributes for intrinsics

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 07:00:46 PST 2022


nikic created this revision.
nikic added reviewers: tlively, asb, pmatos.
Herald added subscribers: StephenFan, ecnelises, sunfish, jgravelle-google, sbc100, dschuff.
Herald added a project: All.
nikic requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

This switches wasm intrinsics to use default attributes, i.e. nofree, nosync, nocallback and willreturn. Especially willreturn is required to avoid optimization regressions in the future.

The attributes are omitted from the trapping fptoi intrinsics (where I assume trapping is considered well-defined, and as such these aren't willreturn) and the atomic intrinsics, which aren't nosync


https://reviews.llvm.org/D137551

Files:
  llvm/include/llvm/IR/IntrinsicsWebAssembly.td
  llvm/test/CodeGen/WebAssembly/lower-wasm-ehsjlj.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137551.473654.patch
Type: text/x-patch
Size: 22797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/1ceffceb/attachment.bin>


More information about the llvm-commits mailing list