[PATCH] D135876: [InstCombine] Remove redundant splats in InstCombineVectorOps

Matt Devereau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 06:15:18 PST 2022


MattDevereau added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:2638-2640
+  if (Instruction *I = simplifyBinOpSplats(SVI)) {
+    return I;
+  }
----------------
spatel wrote:
> LLVM generally omits brackets on a one-line `if` body:
> https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
I forgot to remove this when doing some local changes. I'll remove this on push.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135876/new/

https://reviews.llvm.org/D135876



More information about the llvm-commits mailing list