[PATCH] D135876: [InstCombine] Remove redundant splats in InstCombineVectorOps

[Matt Devereau via Phabricator via llvm-commits]

MattDevereau updated this revision to Diff 473639.
MattDevereau added a comment.

Reverted the addition of `SVI.isZeroEltSplat()` to a more primitive and explicit check. This check had the unintended side effect of accepting splats from the first element of the second splat operand, which caused incorrectness as poison elements were being splatted.
Added test `shuffle_op2_0th_element_mask`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135876/new/

https://reviews.llvm.org/D135876

Files:
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
  llvm/test/Transforms/InstCombine/shuffle-binop.ll
  llvm/test/Transforms/VectorCombine/AArch64/insert-shuffle-binop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135876.473639.patch
Type: text/x-patch
Size: 28157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/80579188/attachment.bin>