[PATCH] D135685: [Visualizers] Add natvis visualizers for various internal llvm classes

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

Cheers - LGTM with a couple of minors - setting "Tools->Options->Debugging->Ouput Window.NatvisDiagnosticMessages" to verbose seems to be (mostly) happy.

I'm wondering whether this needs to be sorted better (alphanumerically or by context) to make it easier to keep track of all the classes, but its not really that important.



================
Comment at: llvm/utils/LLVMVisualizers/llvm.natvis:304
+  <Type Name="llvm::SDNode">
+    <DisplayString>$(Type) {getOperationName(nullptr)}</DisplayString>
+    <Expand>
----------------
Does this work? It always seems to display "{llvm::SDNode ???}" for me



================
Comment at: llvm/utils/LLVMVisualizers/llvm.natvis:41
+    <DisplayString Condition="Length < 4">{Data,[Length]}</DisplayString>
+    <DisplayString Condition="Length > 3">{Length} elements</DisplayString>
     <Expand>
----------------
RKSimon wrote:
> Trass3r wrote:
> > RKSimon wrote:
> > > Any chance that we can have ArrayRef and SmallVectorImpl show a more similar representation?
> > You mean simplifying SmallVector?
> > Or changing this one?
> Whichever is easier would be fine
I'm seeing a NatVis verbose warning from this:
```
Natvis: E:\llvm\llvm-project\llvm\utils\LLVMVisualizers\llvm.natvis(30,4): Warning: Unable to load a visualized preview for type 'llvm::ArrayRef<int>' because the conditions of all <DisplayString> elements were false.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135685/new/

https://reviews.llvm.org/D135685