[PATCH] D136483: [mlir][MemRefToLLVM] Reuse existing lowering for collaspe/expand_shape

[Matthias Springer via Phabricator via llvm-commits]

springerm added a comment.

> Collapsing non-contiguous dimensions is undefined behavior.

Non-contiguous dimensions of size 1 can be collapsed. But for dims of size 1 it doesn't really make sense to have a stride in the first place; so such a stride could be simplified, e.g., to just `1`. Is that what's happening here?

(Collapsing non-contiguous dimensions of size >1 should crash at runtime, but we don't generate the assert at the moment.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136483/new/

https://reviews.llvm.org/D136483