[PATCH] D137481: [TargetLowering] Do not shrink shift amount in ShrinkDemandedOp

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 22:20:08 PST 2022


bcl5980 added a comment.

In D137481#3910229 <https://reviews.llvm.org/D137481#3910229>, @craig.topper wrote:

> This is only called for constant shift amounts. Won't LegalizeDAG fix it if DAG combine changes it after legalization? Have you seen a failure in a larger test?

The motivation of this change comes from D136014 <https://reviews.llvm.org/D136014>. I compare two shift amount by apint trigged an assert. It happens in DAGCombiner, LegalizeDAG haven't executed yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137481/new/

https://reviews.llvm.org/D137481



More information about the llvm-commits mailing list