[PATCH] D137035: [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport

Sun Nov 6 08:00:08 PST 2022

mgorny added a comment.

In D137035#3910690 <https://reviews.llvm.org/D137035#3910690>, @awarzynski wrote:

> In D137035#3910595 <https://reviews.llvm.org/D137035#3910595>, @mgorny wrote:
>
>> @awarzynski, any chance you'd be able to help me figure out why https://lab.llvm.org/buildbot/#/builders/175/builds/20242 is failing with this change? I really have no clue how it could be related.
>
> Also no clue :( I don't quite understand the semantics of `EXCLUDE_FROM_ALL` :/
>
> I'm not really active in the Flang area anymore and never really used standalone builds myself (that buildbot was mainly set-up to make sure that we don't break things that other developers use). This Discourse post <https://discourse.llvm.org/t/rfc-stand-alone-build-support/61291/42> might be helpful - that's the last time I looked at standalone builds in Flang.  One thing worth pointing out - these unittests are indeed used/enabled in standalone builds of LLVM Flang. IIRC, other sub-projects "don't care" about unittests when built as standalone?

Actually, the way they're done in Flang seems completely different than e.g. in Clang or LLDB. Other projects include the respective subdirectories of LLVM to get normal build targets whereas Flang seems to define them locally instead.

> Are you able to reproduce locally? Also, CC @kiranchandramohan who is active in Flang at our end.

To be honest, I haven't set up a proper standalone build of Flang since my last patchset, and I was hoping I could avoid that for the time being.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137035/new/

https://reviews.llvm.org/D137035