[PATCH] D137035: [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport

Sun Nov 6 07:22:05 PST 2022

awarzynski added a subscriber: kiranchandramohan.
awarzynski added a comment.

In D137035#3910595 <https://reviews.llvm.org/D137035#3910595>, @mgorny wrote:

> @awarzynski, any chance you'd be able to help me figure out why https://lab.llvm.org/buildbot/#/builders/175/builds/20242 is failing with this change? I really have no clue how it could be related.

Also no clue :( I don't quite understand the semantics of `EXCLUDE_FROM_ALL` :/

I'm not really active in the Flang area anymore and never really used standalone builds myself (that buildbot was mainly set-up to make sure that we don't break things that other developers use). This Discourse post <https://discourse.llvm.org/t/rfc-stand-alone-build-support/61291/42> might be helpful - that's the last time I looked at standalone builds in Flang.  One thing worth pointing out - these unittests are indeed used/enabled in standalone builds of LLVM Flang. IIRC, other sub-projects "don't care" about unittests when built as standalone?

Are you able to reproduce locally? Also, CC @kiranchandramohan who is active in Flang at our end.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137035/new/

https://reviews.llvm.org/D137035