[PATCH] D137384: [MC][LoongArch] Fix needsRelocateWithSymbol() implementation

[Youling Tang via Phabricator via llvm-commits]

tangyouling added a comment.

> I think you mean most relocations can use the section symbol plus offset representation.
> Some relocations need to use the original symbol anyway, e.g. ifunc symbols.

Hmm, it should be.

> Do we need to make a custom implementation which returns false for R_LARCH_32_PCREL, R_LARCH_PCALA*, and R_LARCH_B*, true for others?

It feels better to add a custom implementation. But I'm not quite sure which relocation types need to return true, and which return false ? (it's difficult for me to distinguish these correctly :( )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137384/new/

https://reviews.llvm.org/D137384