[PATCH] D137384: [MC][LoongArch] Fix needsRelocateWithSymbol() implementation

Xi Ruoyao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 20:28:28 PDT 2022


xry111 added a comment.

Hmm, BFD linker does not support `R_LARCH_GOT_PC_{HI12,LO20}` with a non-zero addend:

  case R_LARCH_GOT_PC_HI20:
  case R_LARCH_GOT_HI20:
    /* Calc got offset.  */
      {
        unresolved_reloc = false;
        BFD_ASSERT (rel->r_addend == 0);

Do we need to make a custom implementation which returns false for `R_LARCH_32_PCREL`, `R_LARCH_PCALA*`, and `R_LARCH_B*`, true for others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137384/new/

https://reviews.llvm.org/D137384



More information about the llvm-commits mailing list