[PATCH] D136331: [Assignment Tracking Analysis][4/*] Plumb analysis results into SelectionDAG

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 09:06:00 PDT 2022


StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

Mostly boilerplate, but the substance of this LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1369
+
+  LLVM_DEBUG(dbgs() << "processDbgDeclares: setVariableDbgInfo Var=" << *Var
+                    << ", Expr=" << *Expr << ",  FI=" << FI
----------------
Since `processDbgDeclares` is not the only function that will call this now-extracted code, probably best to just use the name of this function directly so as not to mislead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136331/new/

https://reviews.llvm.org/D136331



More information about the llvm-commits mailing list