[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In D137149#3904770 <https://reviews.llvm.org/D137149#3904770>, @ebrevnov wrote:

> In D137149#3904715 <https://reviews.llvm.org/D137149#3904715>, @nhaehnle wrote:
>
>> It's sort of strange to have a pass gate reference in the LLVMContext and not use it. But you could just have a `StandardInstrumentations::setPassGate` method to store a reference locally.
>
> IMHO, we should make StandardInstrumentations context aware... Alternative to `StandardInstrumentations::setPassGate` could be passing LLVMContext  during StandardInstrumentations construction.

Yeah, the use cases I'm aware of are pretty much tied to an LLVMContext already anyway, so that seems fine to me too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137149/new/

https://reviews.llvm.org/D137149