[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 03:25:44 PDT 2022


ebrevnov added a comment.

In D137149#3904715 <https://reviews.llvm.org/D137149#3904715>, @nhaehnle wrote:

> It's sort of strange to have a pass gate reference in the LLVMContext and not use it. But you could just have a `StandardInstrumentations::setPassGate` method to store a reference locally.

IMHO, we should make StandardInstrumentations context aware... Alternative to `StandardInstrumentations::setPassGate` could be passing LLVMContext  during StandardInstrumentations construction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137149/new/

https://reviews.llvm.org/D137149



More information about the llvm-commits mailing list