[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one
Evgeniy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 2 21:58:20 PDT 2022
ebrevnov added a comment.
In D137149#3903334 <https://reviews.llvm.org/D137149#3903334>, @aeubanks wrote:
> ideally we wouldn't have to pass LLVMContext if possible, it makes it easier for users of this API to mess up. the optional `FAM` parameter to `StandardInstrumentations` already bothers me
I agree. Let's see if we can find something better...
> I'd like to understand your motivation for this change to see if there's a nicer way of doing this (maybe there isn't and this patch is the way to go). is it to make `-opt-bisect-limit` work per-LLVMContext? or a custom downstream `OptPassGate`?
The motivation is to make `-opt-bisect-limit` work per-LLVMContext' (as it was supposed to work I guess). In our environment, multiple threads are doing compilations in parallel and we want to be able to bisect only some particular ones.
> also the `Pass*` -> `StringRef` part of this patch looks like it can be split out into a separate patch
Sure, that can be done if requested
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137149/new/
https://reviews.llvm.org/D137149
More information about the llvm-commits
mailing list