[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 13:10:13 PDT 2022


aeubanks added a comment.

ideally we wouldn't have to pass LLVMContext if possible, it makes it easier for users of this API to mess up. the optional `FAM` parameter to `StandardInstrumentations` already bothers me

I'd like to understand your motivation for this change to see if there's a nicer way of doing this (maybe there isn't and this patch is the way to go). is it to make `-opt-bisect-limit` work per-LLVMContext? or a custom downstream `OptPassGate`?

also the `Pass*` -> `StringRef` part of this patch looks like it can be split out into a separate patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137149/new/

https://reviews.llvm.org/D137149



More information about the llvm-commits mailing list