[PATCH] D71729: [CommandLine] Add template instantiations of cl::parser for long and long long.
Riyaz V Puthiyapurayil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 2 16:54:18 PDT 2022
RVP added inline comments.
Herald added subscribers: StephenFan, bollu.
Herald added a project: All.
================
Comment at: llvm/include/llvm/Support/CommandLine.h:997
+//
+template <> class parser<long> final : public basic_parser<long> {
+public:
----------------
Why is this declared as `final`. None of the other parsers are `final`. The CommandLine documentation for writing custom parsers shows that users may extend `parser<unsigned>`. So why can't they extend `parser<long>`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71729/new/
https://reviews.llvm.org/D71729
More information about the llvm-commits
mailing list