[llvm] 48732d3 - SPARC: Register null target streamer

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 16:05:48 PDT 2022


Author: Matt Arsenault
Date: 2022-11-02T16:05:34-07:00
New Revision: 48732d3541df14f6206b0e93f0e08b4eabd1176c

URL: https://github.com/llvm/llvm-project/commit/48732d3541df14f6206b0e93f0e08b4eabd1176c
DIFF: https://github.com/llvm/llvm-project/commit/48732d3541df14f6206b0e93f0e08b4eabd1176c.diff

LOG: SPARC: Register null target streamer

Fixes null dereference in emitFunctionBodyStart for 64-bit

Added: 
    

Modified: 
    llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
    llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
    llvm/test/CodeGen/SPARC/64bit.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp b/llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
index b11c786e7856d..d6688c31334c2 100644
--- a/llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
+++ b/llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
@@ -84,6 +84,10 @@ static MCTargetStreamer *createTargetAsmStreamer(MCStreamer &S,
   return new SparcTargetAsmStreamer(S, OS);
 }
 
+static MCTargetStreamer *createNullTargetStreamer(MCStreamer &S) {
+  return new SparcTargetStreamer(S);
+}
+
 static MCInstPrinter *createSparcMCInstPrinter(const Triple &T,
                                                unsigned SyntaxVariant,
                                                const MCAsmInfo &MAI,
@@ -122,6 +126,9 @@ extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeSparcTargetMC() {
     // Register the asm streamer.
     TargetRegistry::RegisterAsmTargetStreamer(*T, createTargetAsmStreamer);
 
+    // Register the null streamer.
+    TargetRegistry::RegisterNullTargetStreamer(*T, createNullTargetStreamer);
+
     // Register the MCInstPrinter
     TargetRegistry::RegisterMCInstPrinter(*T, createSparcMCInstPrinter);
   }

diff  --git a/llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h b/llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
index 27976d166067b..ef28afa06bffb 100644
--- a/llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
+++ b/llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
@@ -22,9 +22,9 @@ class SparcTargetStreamer : public MCTargetStreamer {
 public:
   SparcTargetStreamer(MCStreamer &S);
   /// Emit ".register <reg>, #ignore".
-  virtual void emitSparcRegisterIgnore(unsigned reg) = 0;
+  virtual void emitSparcRegisterIgnore(unsigned reg){};
   /// Emit ".register <reg>, #scratch".
-  virtual void emitSparcRegisterScratch(unsigned reg) = 0;
+  virtual void emitSparcRegisterScratch(unsigned reg){};
 };
 
 // This part is for ascii assembly output

diff  --git a/llvm/test/CodeGen/SPARC/64bit.ll b/llvm/test/CodeGen/SPARC/64bit.ll
index c61476eb2265d..c079d901a03d1 100644
--- a/llvm/test/CodeGen/SPARC/64bit.ll
+++ b/llvm/test/CodeGen/SPARC/64bit.ll
@@ -1,5 +1,6 @@
 ; RUN: llc < %s -march=sparcv9 -mattr=+popc -disable-sparc-delay-filler -disable-sparc-leaf-proc | FileCheck %s
 ; RUN: llc < %s -march=sparcv9 -mattr=+popc | FileCheck %s -check-prefix=OPT
+; RUN: llc %s -march=sparcv9 -mattr=+popc -filetype=null
 
 ; CHECK-LABEL: ret2:
 ; CHECK: mov %i1, %i0


        


More information about the llvm-commits mailing list