[PATCH] D137292: [lsan] Fix stack buffer overwrite in SuspendedThreadsListMac::GetRegistersAndSP

Wed Nov 2 15:43:10 PDT 2022

vitalybuka added a comment.

In D137292#3903767 <https://reviews.llvm.org/D137292#3903767>, @kubamracek wrote:

>> BTW. Repro is very trivial, would you like to add a regression test?
>
> Do you have a specific test/approach in mind? I think this is well covered by existing tests, basically all LSan tests exercise this codepath. But the bug (the hang) only triggers on arm64 and I bet the reason why CI and buildbots didn't discover this is that they don't actually run on Apple Silicon Mac hardware.

You are right. LGTM without the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137292/new/

https://reviews.llvm.org/D137292