[PATCH] D136867: [flang][OpenMP] Add parser support for Requires directive

Dan Palermo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 14:57:45 PDT 2022


dpalermo requested changes to this revision.
dpalermo added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Parser/openmp-parsers.cpp:284-294
+    "REVERSE_OFFLOAD" >>
+        construct<OmpClause>(construct<OmpClause::ReverseOffload>()) ||
+    "UNIFIED_ADDRESS" >>
+        construct<OmpClause>(construct<OmpClause::UnifiedAddress>()) ||
+    "UNIFIED_SHARED_MEMORY" >>
+        construct<OmpClause>(construct<OmpClause::UnifiedSharedMemory>()) ||
+    "ATOMIC_DEFAULT_MEM_ORDER" >>
----------------
These should probably be ordered alphabetically with the other clauses to match the existing code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136867/new/

https://reviews.llvm.org/D136867



More information about the llvm-commits mailing list