[PATCH] D137155: [MIRVRegNamer] Avoid opcode hash collision

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 12:10:16 PDT 2022


plotfi accepted this revision.
plotfi added a subscriber: aditya_nandakumar.
plotfi added a comment.
This revision is now accepted and ready to land.

LGTM, Nice work John.

Would format_hex_no_prefix be replaceable with std::format once C++20 for LLVM drops?

@aditya_nandakumar Any thoughts? Are you folks still using the pass in places where the change in hashing could break things?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137155/new/

https://reviews.llvm.org/D137155



More information about the llvm-commits mailing list