[PATCH] D131628: [LangRef] Add description for nocallback attribute

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added a comment.

In D131628#3899687 <https://reviews.llvm.org/D131628#3899687>, @nlopes wrote:

> I meant to drop the attribute for the functions that are linked in. I agree it doesn't have to be dropped for the external functions.

Ah, sorry, I guess I hadn't realized that this had any effect on defined functions.
Doing a quick sweep of the uses, it looks like one of them checks that the function is a declaration first, while other's doesn't seem to.
It does seem that stripping this from definitions during LTO link seems less error-prone than declaring that it mustn't have any effect on definitions. If we wanted to go the latter route, we could create an accessor on the Function type to standardize the logic, but you'd have to remember to use it everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131628/new/

https://reviews.llvm.org/D131628