[PATCH] D131628: [LangRef] Add description for nocallback attribute

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 10:50:49 PDT 2022


nlopes added a comment.

In D131628#3899670 <https://reviews.llvm.org/D131628#3899670>, @mysterymath wrote:

> In D131628#3898605 <https://reviews.llvm.org/D131628#3898605>, @nlopes wrote:
>
>> So, dropping `nocallback` during linking seems the way to go (and adjust the docs accordingly). Once you link, you can do inter-proc analysis and recover that info if needed anyway.
>
> This would make Clang the only implementation of `__attribute__((leaf))` to do so.
> It's also not generally possible to recover the nocallback information about functions external to the LTO unit, which is the only thing `__attribute__((leaf))` is actually good for in full LTO.

Well, I haven't seen any numbers regarding how useful this attribute is, so I can't comment on that.
I meant to drop the attribute for the functions that are linked in. I agree it doesn't have to be dropped for the external functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131628/new/

https://reviews.llvm.org/D131628



More information about the llvm-commits mailing list