[PATCH] D136525: [M68k] Add codegen pattern for atomic load / store

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kTargetMachine.cpp:161
 
+void M68kPassConfig::addIRPasses() { addPass(createAtomicExpandPass()); }
+
----------------
0x59616e wrote:
> RKSimon wrote:
> > 0x59616e wrote:
> > > RKSimon wrote:
> > > > Also - do we need to add an pipeline.ll test file?
> > > What is pipeline.ll ?
> > https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
> > https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/ARM/O3-pipeline.ll
> > https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/X86/opt-pipeline.ll
> > 
> > Different backends do it differently, but basically its a test file that checks what passes have been run at all/some opt levels
> Thanks. This looks interesting. As far as I'm concerned, there is no reason not to add this one in M68k.
So do we need to add TargetPassConfig::addIRPasses() to this call now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136525/new/

https://reviews.llvm.org/D136525