[PATCH] D133943: [Utils] Match function return type and other attributes on the definition in update_cc_test_checks

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 09:55:17 PDT 2022


jdoerfert added a comment.

In D133943#3823710 <https://reviews.llvm.org/D133943#3823710>, @arichardson wrote:

> I have also wanted this in the past, and I don't think the church should be too bad since many tests don't use this flag and if they do it will only affect a few lines without any knock on effects.

I am not 100% sure this is the case. Could we check? Grep all the tests for the flag, run the update script on them as a NFC commit after this one. Verify they all run properly and the churn is not too bad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133943/new/

https://reviews.llvm.org/D133943



More information about the llvm-commits mailing list