[PATCH] D130784: [AMDGPU] Support LDS spilling

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 02:47:23 PDT 2022


piotr added a comment.

In D130784#3702505 <https://reviews.llvm.org/D130784#3702505>, @scchan wrote:

> Just briefly glanced through the code and it seems that it doesn't look at whether a kernel has dynamic LDS or not because LDS spilling has to be disabled in that case, can you confirm?

Good point; sorry, I missed your comment initially. It appears we don't track that in MFI though, so that requires some extra code (possibly checking that no extern LDS and no LDS kernel args are used).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130784/new/

https://reviews.llvm.org/D130784



More information about the llvm-commits mailing list