[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 00:22:01 PDT 2022


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for the patch!



================
Comment at: llvm/test/CodeGen/X86/avx512-gfni-intrinsics.ll:29
+;
+; X86NOBW-LABEL: test_vgf2p8affineinvqb_128:
+; X86NOBW:       # %bb.0:
----------------
Since we are able to lower the mask version intrinsics, we have 3 choices for the FE support:
1. Still disallow Clang intrinsics for AVX512F. This matches with GCC too;
2. Allow the mask intrinsics as well. This matches with Intrinsic Guide and SDM somehow;
3. And mixed for AVX512F and AVX512BW as in this revision;
I slightly prefer to 1). I think the intention of the EVEX design is to use the masked instructions directly, so it should always imply AVX512BW in reality. But I'm fine with any way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137036/new/

https://reviews.llvm.org/D137036



More information about the llvm-commits mailing list