[PATCH] D136227: [LoopVectorize] Fix crash on "Cannot dereference end iterator!"(PR56627)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM with the additional comments, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll:3
+
+; Check that we can vectorize this loop without crashing.
+
----------------
Would be good to check if we are at least vectorizing (i.e. check at least for `vector.body:` )


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll:17
+
+bb4:
+  %tmp5 = fadd float %tmp2, 0.000000e+00
----------------
this block can be folded in the previous one.



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll:18
+bb4:
+  %tmp5 = fadd float %tmp2, 0.000000e+00
+  %tmp6 = mul i32 0, 0
----------------
might be better to increment this by a value != 0.0



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll:24
+bb8:
+  %tmp9 = phi float [ %tmp5, %bb4 ]
+  ret void
----------------
Better to return the value to make it used.



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll:51
+bb4:
+  %tmp5 = fadd float %tmp2, 0.000000e+00
+  %tmp6 = mul i32 0, 0
----------------
might be better to increment this by a value `!= 0.0`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136227/new/

https://reviews.llvm.org/D136227