[PATCH] D136227: [LoopVectorize] Fix crash on "Cannot dereference end iterator!"(PR56627)

[LiDongjin via Phabricator via llvm-commits]

LiDongjin updated this revision to Diff 470690.
LiDongjin added a comment.

delete brackets


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136227/new/

https://reviews.llvm.org/D136227

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll


Index: llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/LoopVectorize/AArch64/pr56627.ll
@@ -0,0 +1,26 @@
+; RUN: opt < %s -S -passes=loop-vectorize | FileCheck %s
+
+; Check that we can vectorize this loop without crashing.
+
+target triple = "aarch64-none-linux-gnu"
+define void @quux() {
+; CHECK: @quux
+bb:
+  br label %bb1
+
+bb1:
+  %tmp = phi i64 [ %tmp3, %bb4 ], [ 0, %bb ]
+  %tmp2 = phi float [ %tmp5, %bb4 ], [ 0.000000e+00, %bb ]
+  %tmp3 = add nsw i64 %tmp, 1
+  br label %bb4
+
+bb4:
+  %tmp5 = fadd float %tmp2, 0.000000e+00
+  %tmp6 = mul i32 0, 0
+  %tmp7 = icmp sgt i64 %tmp, 0
+  br i1 %tmp7, label %bb8, label %bb1
+
+bb8:
+  %tmp9 = phi float [ %tmp5, %bb4 ]
+  ret void
+}
Index: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -6563,10 +6563,9 @@
       return None;
     RetI = RetI->user_back();
   }
-  if (match(RetI, m_Mul(m_Value(), m_Value())) &&
+
+  if (match(RetI, m_OneUse(m_Mul(m_Value(), m_Value()))) &&
       RetI->user_back()->getOpcode() == Instruction::Add) {
-    if (!RetI->hasOneUser())
-      return None;
     RetI = RetI->user_back();
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136227.470690.patch
Type: text/x-patch
Size: 1378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221026/98e5d340/attachment.bin>