[PATCH] D136954: DiagnosticInfo: Report function location for resource limits

Fri Oct 28 11:27:37 PDT 2022

arsenm added inline comments.

================
Comment at: clang/test/Misc/backend-resource-limit-diagnostics.hip:2
+// RUN: not %clang_cc1 -debug-info-kind=standalone -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -S -o /dev/null < %s 2>&1 | FileCheck %s
+// FIXME: Use -emit-codegen-only
+
----------------
paulkirth wrote:
> Is this planned for this patch? or for future refactoring in multiple tests?
I'm not sure. I currently cannot comprehend why this flag exists. It's only used in a handful of tests, and its effect seems to be to just create an edge case to crash codegen when there's no target streamer

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136954/new/

https://reviews.llvm.org/D136954