[PATCH] D136954: DiagnosticInfo: Report function location for resource limits

[Paul Kirth via Phabricator via llvm-commits]

paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.

This is basically LGTM from my perspective. I'd suggest getting some feedback from someone who works more on this part of Clang before landing, but I think it fixes the inconsistency nicely.



================
Comment at: clang/test/Misc/backend-resource-limit-diagnostics.hip:1
+// RUN: not %clang_cc1 -debug-info-kind=standalone -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -S -o /dev/null < %s 2>&1 | FileCheck %s
+// FIXME: Use -emit-codegen-only
----------------
Does this need  `// REQUIRES: amdgpu-registered-target`, like the test in `backend-resourse-limit-diagnostics.cl`?


================
Comment at: clang/test/Misc/backend-resource-limit-diagnostics.hip:2
+// RUN: not %clang_cc1 -debug-info-kind=standalone -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -S -o /dev/null < %s 2>&1 | FileCheck %s
+// FIXME: Use -emit-codegen-only
+
----------------
Is this planned for this patch? or for future refactoring in multiple tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136954/new/

https://reviews.llvm.org/D136954