[PATCH] D136713: [SDAG] avoid vector extract/insert around binop

Fri Oct 28 08:09:38 PDT 2022

spatel added a comment.

In D136713#3891887 <https://reviews.llvm.org/D136713#3891887>, @thakis wrote:

> In D136713#3890855 <https://reviews.llvm.org/D136713#3890855>, @dyung wrote:
>
>> @spatel, after this commit, we started seeing an assertion failure being hit in two of our internal tests. I have filed this as issue #58661, can you take a look?
>
> Thanks for filing this! We hit the same problem, and the fix fixes it for us too.
>
> It would've been nice if this had been reverted once the problem was found – then the probably would've gone away 7 hours earlier and I wouldn't have had to spend time to track it down as well :) If things take a while to fix, I think it's good to revert first and then fix asynchronously, to save the duplicate work of several people tracking down their compile failures to the same commit, only to discover that the problem is already known.

I agree - if there's a clear connection between a patch and a crash, then please do revert. This was actually the best I could have done to post a fix given the timing; it was patched in about an hour after waking up and seeing the bug report. :)
Sorry about the bug, but thanks to all for the reports and reduced tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136713/new/

https://reviews.llvm.org/D136713