[PATCH] D136148: [AMDGPU][NFC] Split MC tests into promoted from VOP2 to VOP3 and only VOP3

Tue Oct 25 13:48:24 PDT 2022

dp added a comment.

The patch may be useful, but I’m concerned with file naming. I think the naming should be consistent. Right now we have `vop3`, `vop3c`, `vop3cx` and now `vop3_from…`. Maybe we should think over test naming?

IMO `vop3_from_vop2_dpp16` is questionable.

To tell you the truth, I considered splitting VOP3 opcodes into native and promoted parts but was unable to find good file names and abandoned the idea.

Any proposals to make the naming consistent?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136148/new/

https://reviews.llvm.org/D136148