[PATCH] D136690: [AArch64][SVE2] Add the SVE2.1 shift-and-narrow instructions

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:8714
+  let Inst{15-14} = 0b00;
+  let Inst{13-12} = opc;
+  let Inst{11-10} = 0b10;
----------------
david-arm wrote:
> paulwalker-arm wrote:
> > Sorry I missed this during my previous review but looking at the decode table `opc` should be `Inst{13-11}`.
> Sure I can do that, except I'll be passing in exactly the same bit 11 for all instructions.
Yep I understand, I just prefer to match the encoding group so there's potentially less work when adding new instructions later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136690/new/

https://reviews.llvm.org/D136690