[PATCH] D136690: [AArch64][SVE2] Add the SVE2.1 shift-and-narrow instructions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 23:04:42 PDT 2022


david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:8714
+  let Inst{15-14} = 0b00;
+  let Inst{13-12} = opc;
+  let Inst{11-10} = 0b10;
----------------
paulwalker-arm wrote:
> Sorry I missed this during my previous review but looking at the decode table `opc` should be `Inst{13-11}`.
Sure I can do that, except I'll be passing in exactly the same bit 11 for all instructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136690/new/

https://reviews.llvm.org/D136690



More information about the llvm-commits mailing list