[PATCH] D136808: Refactor Tblgen DecoderEmitter to allow multiple language output

Thu Oct 27 19:51:57 PDT 2022

Rot127 added a comment.

In D136808#3888821 <https://reviews.llvm.org/D136808#3888821>, @myhsu wrote:

> 

> To my best understanding, you're trying to add another layer of abstraction between disassembler generation logics and the code printer.

Yes, this is the idea.

In D136808#3888821 <https://reviews.llvm.org/D136808#3888821>, @myhsu wrote:

> because this new printer interface can co-exist with the current code printing logics, right?

In what sense do you mean "co-exist"?
Currently the generator logic writes to `OS` whenever it has some code piece ready (this seems to be the case for all backends relevant here).
With this change it no longer does it, but passes the generated code pieces on. Once all the code is generated the `Printer` writes it to `OS`.

So as long as one backend is updated at a time there is no problem. Since backends do not share printing logic in any way.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136808/new/

https://reviews.llvm.org/D136808