[PATCH] D136808: Refactor Tblgen DecoderEmitter to allow multiple language output

Rot127 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 19:34:32 PDT 2022


Rot127 added a comment.

In D136808#3888064 <https://reviews.llvm.org/D136808#3888064>, @0x59616e wrote:

> Thanks for this patch !
>
> It is difficult to see the changes you made. Could you separate this into two patches -- the first one contains the all the changes except the functional change; the second one contains the functional change you made.

I updated the diff two more times they can be selected now in the history. Hopefully this was the right way of doing it?
Sorry if not. I'm new to Phabricator but wanted to have it available quickly for you guys.

There are only two none functional changes in the functional commit: one renaming of the statistic variables and the extraction of types from one header file to another (easy to spot).
Sorry if this isn't 100% clean, but those changes were made too late and couldn't easily be resorted with `git rebase -i`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136808/new/

https://reviews.llvm.org/D136808



More information about the llvm-commits mailing list