[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

Thu Oct 27 09:29:23 PDT 2022

clementval added inline comments.

================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:828
+    (`use_device_addr` `(` $use_device_addr^ `:` type($use_device_addr) `)` )?
+    (`map` `(` $map_type_modifier_val `,` $map_type_val `:` $map_operands^ `:` type($map_operands) `)` )?
+    $region attr-dict
----------------
It's not clear how to you deal with multiple map clauses here? Or do you plan to have an operation generation per map clause coming from the frontend?

================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:879
+    (`nowait` $nowait^ )?
+    (`map` `(` $map_type_modifier_val `,` $map_type_val `:` $map_operands^ `:` type($map_operands) `)` )?
+    attr-dict
----------------
Same comment here about multiple map clauses. You probably need a custom parser/printer for the map part together with the change requested by @TIFitis. 

================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:930
+    (`nowait` $nowait^ )?
+    (`map` `(` $map_type_modifier_val `,` $map_type_val `:` $map_operands^ `:` type($map_operands) `)` )?
+    attr-dict
----------------
Same comment here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131915/new/

https://reviews.llvm.org/D131915