[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

[Akash Banerjee via Phabricator via llvm-commits]

TIFitis requested changes to this revision.
TIFitis added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:817-818
+             Variadic<AnyType>:$use_device_addr,
+             MapTypeModifierAttr:$map_type_modifier_val,
+             MapTypeAttr:$map_type_val,
+             Variadic<AnyType>:$map_operands);
----------------
I think these should be Variadic to allow multiple map clauses.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:871-872
+             UnitAttr:$nowait,
+             MapTypeModifierAttr:$map_type_modifier_val,
+             MapTypeAttr:$map_type_val,
+             Variadic<AnyType>:$map_operands);
----------------
I think these should be Variadic to allow multiple map clauses.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:922-923
+             UnitAttr:$nowait,
+             MapTypeModifierAttr:$map_type_modifier_val,
+             MapTypeAttr:$map_type_val,
+             Variadic<AnyType>:$map_operands);
----------------
I think these should be Variadic to allow multiple map clauses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131915/new/

https://reviews.llvm.org/D131915